Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!
is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh
.Rationale for this change
Currently,
arrow
is one of the elements that must be disabled to enableno_std
support. Additionally, not every use-case requiresarrow
. So, it is gated behind a features flag (feature = "arrow"). However, there are many instances of #[cfg(feature = "arrow")] throughout the codebase, which leaves the code cluttered.What changes are included in this PR?
This PR isolates the code using
arrow
into a separate module.TODO
Only the documentation part is left, which I will do in the next commit, other than that the code is working fine.
/claim #237