Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Isolate arrow code #237 #267

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

melsonic
Copy link

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

Currently, arrow is one of the elements that must be disabled to enable no_std support. Additionally, not every use-case requires arrow. So, it is gated behind a features flag (feature = "arrow"). However, there are many instances of #[cfg(feature = "arrow")] throughout the codebase, which leaves the code cluttered.

What changes are included in this PR?

This PR isolates the code using arrow into a separate module.

TODO

Only the documentation part is left, which I will do in the next commit, other than that the code is working fine.

/claim #237

@algora-pbc algora-pbc bot mentioned this pull request Oct 12, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant