Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle slash at endpoint #572

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Handle slash at endpoint #572

merged 1 commit into from
Sep 23, 2024

Conversation

adamconnelly
Copy link
Contributor

@adamconnelly adamconnelly commented Sep 23, 2024

Description of the change

Updated the code that builds the URL for the GraphQL API to handle the situation where the api_key_endpoint setting includes a trailing /.

This is the PR from @akmal-spacelift from here.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@adamconnelly adamconnelly force-pushed the handle-slash-at-endpoint branch 2 times, most recently from 72d7df3 to cfca310 Compare September 23, 2024 08:22
Updated the code that builds the URL for the GraphQL API to handle the situation where the `api_key_endpoint` setting includes a trailing `/`.
Copy link
Contributor

@akmal-spacelift akmal-spacelift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally / lgtm

@akmal-spacelift akmal-spacelift merged commit 1eeddc6 into main Sep 23, 2024
7 checks passed
@akmal-spacelift akmal-spacelift deleted the handle-slash-at-endpoint branch September 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants