Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning to PoST data directory via postdata_metadata.json file #211

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Aug 3, 2023

Description

This introduces versioning to PoST data (closes #210 ). The version is stored inside the postdata_metadata.json file. If no version is present Version 0 is assumed which will be migrated to version 1.

Version 1 has the following changes over Version 0:

  • A missing NonceValue is added if Nonce is present.
  • The ScryptParams that were used to generate the PoST data were added to the metadata file.

These additions allow changes to how the data is stored on disk and allow for smooth migrations from an older version of PoST to a newer version.

TODO:

@fasmat fasmat self-assigned this Aug 3, 2023
@fasmat fasmat changed the title Add versioning to PoST data directory via postdata_metadata.json file WiP: Add versioning to PoST data directory via postdata_metadata.json file Aug 3, 2023
@fasmat fasmat force-pushed the 210-introduce-data-migration branch 2 times, most recently from 5e5bed7 to 8546cbf Compare August 4, 2023 09:12
@fasmat fasmat force-pushed the 210-introduce-data-migration branch from 5683089 to 51e58d3 Compare August 12, 2023 15:31
@fasmat fasmat force-pushed the 210-introduce-data-migration branch 3 times, most recently from 9c13377 to 40c62a1 Compare September 7, 2023 15:17
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Attention: Patch coverage is 52.40964% with 79 lines in your changes missing coverage. Please review.

Project coverage is 59.0%. Comparing base (50539ea) to head (1a97f90).

Files with missing lines Patch % Lines
initialization/migrate_metadata.go 55.5% 38 Missing and 14 partials ⚠️
shared/post_metadata.go 17.2% 22 Missing and 2 partials ⚠️
initialization/initialization.go 81.2% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #211     +/-   ##
=========================================
- Coverage     59.8%   59.0%   -0.9%     
=========================================
  Files           30      31      +1     
  Lines         2291    2407    +116     
=========================================
+ Hits          1372    1421     +49     
- Misses         781     835     +54     
- Partials       138     151     +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat fasmat requested a review from poszu September 12, 2023 08:44
@fasmat fasmat marked this pull request as ready for review September 12, 2023 08:44
@fasmat fasmat changed the title WiP: Add versioning to PoST data directory via postdata_metadata.json file Add versioning to PoST data directory via postdata_metadata.json file Sep 12, 2023
@fasmat fasmat force-pushed the 210-introduce-data-migration branch 3 times, most recently from dde5915 to 2971af2 Compare September 21, 2023 07:39
@fasmat fasmat force-pushed the 210-introduce-data-migration branch from 2971af2 to b8d87fe Compare October 21, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant