Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode nodeid in hex for invalid vrf nonce error #293

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

poszu
Copy link
Collaborator

@poszu poszu commented Jun 13, 2024

Currently the error text is like:

nonce 0 is not valid for node [53 165 217 54 93 19 23 195 0 40 56 18 100 9 225 56 50 28 87 165 101 29 117 132 133 51 108 30 126 90 241 1]

After this change its like:

nonce 0 is not valid for node 35a5d9365d1317c3002838126409e138321c57a5651d758485336c1e7e5af101

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.6%. Comparing base (273b5ad) to head (e074338).

Current head e074338 differs from pull request most recent head 4e7bcbe

Please upload reports for the commit 4e7bcbe to get more accurate results.

Files Patch % Lines
verifying/verifying.go 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           develop    #293   +/-   ##
=======================================
  Coverage     61.6%   61.6%           
=======================================
  Files           30      30           
  Lines         1899    1899           
=======================================
  Hits          1171    1171           
  Misses         590     590           
  Partials       138     138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu poszu requested a review from fasmat June 13, 2024 11:47
verifying/verifying.go Show resolved Hide resolved
@poszu poszu enabled auto-merge June 14, 2024 09:51
@poszu poszu disabled auto-merge June 14, 2024 09:53
@poszu poszu force-pushed the fix-invalid-vrfnonce-error-message branch from e074338 to 4e7bcbe Compare June 14, 2024 10:34
@poszu poszu enabled auto-merge June 14, 2024 10:34
@poszu poszu merged commit 384c99f into develop Jun 14, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants