Do not throw error if NodeEvent does not have type or details #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
brusherru
force-pushed
the
fix-nodeevent-err
branch
from
01fe999
to
a282a39
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pigmej
previously approved these changes
Oct 25, 2024
brusherru
force-pushed
the
fix-nodeevent-err
branch
from
b4c0fd0
to
22191e6
Compare
|
Tested against standalone network. |
brusherru
force-pushed
the
fix-nodeevent-err
branch
from
22191e6
to
ea5b5fd
Compare
brusherru
force-pushed
the
fix-nodeevent-err
branch
from
0d1bad7
to
61ecf6a
Compare
monikasmolarek
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue.
Reported in Discord