-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync/allow-latest #1088
sync/allow-latest #1088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We'll figure out some test for it. In the meantime, would you mind either 1) adding a news fragment to the jwst section or "allow edits from maintainers" on the PR.
If neither, that's ok, just let us know. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the news fragment and made an additional adjustment related to this fix. Also modified the CI context retrieval for JWST to include the state arg "latest". Will need to do the same for other observatories once 12.x is deployed there. There are a number of tests that will need to be added and updated following those deployments so that will be done in a separate PR.
Resolves #1087
Allow "latest" as a CRDS file state in
crds sync
so that it doesn't issue a warning message for all the files it finds in this state.There's no test for
crds sync
with JWST. Only HST. And the testing infrastructure here is so specialized, I'm not sure how to test this. But some pseudocode would be:Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)news fragment change types...
changes/<PR#>.hst.rst
: HST reference fileschanges/<PR#>.jwst.rst
: JWST reference fileschanges/<PR#>.roman.rst
: Roman reference fileschanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.testing.rst
: change to tests or test automationchanges/<PR#>.general.rst
: infrastructure or miscellaneous change