Completed pytests and test conversions tests for tests/test_locking.py #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stscieisenhamer
approved these changes
Sep 20, 2023
test/core/test_locking.py
Outdated
|
|
||
| @mark.locking | ||
| def test_multiprocessing_locking(default_shared_state, capsys): | ||
| _ = config.LOCKING_MODE.set("multiprocessing") |
There was a problem hiding this comment.
If the return is not used in anyway, there is no reason to explicitly save it to nothing. For me, it confuses readability.
There was a problem hiding this comment.
Likewise, I'll space that return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got the locking tests done. Still having ttat slight logging issue but I think as long as it works and is testing the same functionality it can be figured out at a later date.