-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced Composite Model Fitting notebook #74
Advanced Composite Model Fitting notebook #74
Conversation
I pushed up a few commits to fix the dependencies, and I think the build is now working. @hcferguson, can you confirm that https://26-126393017-gh.circle-artifacts.com/0/root/repo/jdat_notebooks/composite_model_fitting/specfit_demo_3.html looks the way you think it should look for this notebook? |
Oh and one clarifying question for @hcferguson: in the requirements file you specified (This also reveals that a bit more detail on what goes in the |
The html rendering looks good to me. Requirements >= should be fine. I was just mindlessly following the example. |
Oh good point! I should change the example to be >=... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM now - thanks @hcferguson !
As discussed in spacetelescope#74
Draft of notebook from @ibusko , annotated and partially revised by @hcferguson to use some of the SpecUtils machinery.