Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-1308: Restore acscteforwardmodel.e hardlink to acscte.e #620

Merged

Conversation

jhunkeler
Copy link
Contributor

The link wrapper for acscteforwardmodel.e was lost when I ported hstcal from WAF to CMake.

The wrapper is used by the following code:
https://github.com/spacetelescope/hstcal/blob/main/pkg/acs/lib/acscte/domaincte.c#L155-L157

My apologies, @mdlpstsci!

@jhunkeler jhunkeler requested a review from a team as a code owner August 5, 2024 22:04
@github-actions github-actions bot added the ACS label Aug 5, 2024
Copy link
Contributor

@mdlpstsci mdlpstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhunkeler Looks good. Thank you for the quick fix.

Also, I forgot about this executable too (!) - no worries.

@mdlpstsci mdlpstsci merged commit 68fe985 into spacetelescope:main Aug 6, 2024
4 checks passed
@mdlpstsci mdlpstsci changed the title Restore acscteforwardmodel.e hardlink to acscte.e HLA-1308: Restore acscteforwardmodel.e hardlink to acscte.e Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants