Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make methods to introspect the viewer (and subset?) names in an application #175

Closed
eteq opened this issue Jun 25, 2020 · 1 comment
Closed
Labels
duplicate This issue or pull request already exists 💤 enhancement New feature or request

Comments

@eteq
Copy link
Contributor

eteq commented Jun 25, 2020

This issue was initially prompted by #159 (comment) but is a bit broader so I'm making it a separate issue.

Basically, the issue here is that all of the convenient data accessors in jdaviz.Application depend on knowing the name of the viewers in the configuration file. This is not desirable because it's not really easily visible to the user, and we do want users to be able to use these APIs for accessing data. So there needs to be a way for a user to ask "what are all the viewers in this app".

I think the most natural way to do this is to simply add a get_viewer_names method to Application? It would then just return a list of all the relevant names that go into the various get_<something>_from_viewer references.

At the same time it probably makes sense to add a similar set of methods for subset names. This is less critical since the user can by-eye see them in the UI, but it's useful for writing code that does something over all of the subsets (and would be applied in combination with the dicts that come out of #159 and #161).

@eteq eteq added the 💤 enhancement New feature or request label Jun 25, 2020
@pllim pllim added the duplicate This issue or pull request already exists label May 26, 2021
@pllim
Copy link
Contributor

pllim commented May 26, 2021

Ops... Didn't see this until after I created #643. Since that one has a JIRA ticket attached to it, I am closing this as duplicate. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists 💤 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants