-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract SpectralRegions from specviz app #161
Extract SpectralRegions from specviz app #161
Conversation
39cd4d2
to
200a9b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly good, but a couple minor inline items. Note thought this collides with the changes in #165 so will something is going to need a rebase...
cce142e
to
d938651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like some of my comments above got mixed up in the rebase, but some of it still applies.
This PR allows for extracting subsets as
SpectralRegion
objects from the specviz app. Requires #159.