-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
greater transparency between glue/widget components and underlying data #4
Comments
Completely agree. This is going to be a bit of a change in this code and some more transparency in the glue-jupyter / glue-core code. I will take a look at this a bit more. |
This ticket is now being tracked at DATJPP-94 |
Related glue-jupyter issue and discussion: glue-viz/glue-jupyter#30 |
See above link for further discussion. |
mariobuikhuizen
pushed a commit
to mariobuikhuizen/jdaviz
that referenced
this issue
May 18, 2021
…n_viewer_bar fix: make viewer bar + viewer fit the available height
pllim
added a commit
that referenced
this issue
Dec 1, 2021
Attempt to fix vertical padding on pixel coordinate div in imviz
duytnguyendtn
referenced
this issue
in duytnguyendtn/jdaviz
Jun 12, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <[email protected]> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (spacetelescope#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <[email protected]>
kecnry
referenced
this issue
in kecnry/jdaviz
Jul 28, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <[email protected]> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <[email protected]>
kecnry
referenced
this issue
in kecnry/jdaviz
Aug 8, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <[email protected]> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <[email protected]>
cshanahan1
pushed a commit
to cshanahan1/jdaviz
that referenced
this issue
Nov 8, 2023
spacetelescope#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <[email protected]> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (spacetelescope#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <[email protected]>
cshanahan1
pushed a commit
to cshanahan1/jdaviz
that referenced
this issue
Nov 15, 2023
spacetelescope#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <[email protected]> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (spacetelescope#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <[email protected]>
pllim
added a commit
that referenced
this issue
Jan 23, 2024
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <[email protected]> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <[email protected]>
gibsongreen
pushed a commit
to gibsongreen/jdaviz
that referenced
this issue
Feb 12, 2024
spacetelescope#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <[email protected]> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (spacetelescope#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The underlying data gets lost somewhere inside the glue/widget components. It's not clear how to get back the underlying FITS data. This is useful in general but will also be necessary I think to implement the "point-and-click" spaxel view and to extract info for display in hover tooltips.
For example, using the cubeviz example notebook, I can access the glue
Data
container which contains limited data components. Similarly, a (limited?) header appears insidedata.meta
butmeta
isn't mentioned anywhere in the documentation on glueData
objects. I discovered it by accident.It might be useful to store the full original data HDU somewhere inside the container or widget and make it transparent as to how to retrieve it.
The text was updated successfully, but these errors were encountered: