Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDAT-1223: Tiling images #521

Closed
3 tasks done
pllim opened this issue Apr 13, 2021 · 4 comments
Closed
3 tasks done

JDAT-1223: Tiling images #521

pllim opened this issue Apr 13, 2021 · 4 comments

Comments

@pllim
Copy link
Contributor

pllim commented Apr 13, 2021

Arrange multiple image viewers in a grid. Implement a "Tile" Button to switch between a "tile view" and allow the user to decide the layout that way.

UI/UX: https://www.stsci.edu/~jkotler/Imviz/#id=9cl0gf&p=imviz_ui&c=1

imviz_tiling

  • Enable ordering/location of tiled images to be changed (e.g., drag them around using ipygoldenlayout).
  • Removable viewers.

Deferred: "Tile" button. Exact UI/UX appearance being handled in the frontend in separate ticket(s).

https://jira.stsci.edu/browse/JDAT-1223

TODO

@pllim pllim added this to the Imviz 1.0 milestone Apr 13, 2021
@pllim
Copy link
Contributor Author

pllim commented May 21, 2021

@astrofrog , @PatrickOgle keeps asking about how various other features (e.g., WCS locking at #613 and so on) would work with this one. Perhaps this needs to be implemented sooner than later.

@pllim
Copy link
Contributor Author

pllim commented May 25, 2021

So, in reviewing #613 , this might already be possible, just not exactly looking like the UX/UI design.

Standalone

Screenshot 2021-05-25 104930

Classic notebook

Screenshot 2021-05-25 105936

@pllim
Copy link
Contributor Author

pllim commented May 25, 2021

To answer some more questions...

Can I load multiple extensions and display them in separate tiles?

Yes. Example:

imviz.load_data('jbt7a3kaq_flc.fits[SCI]')  # SCI,1
imviz.load_data('jbt7a3kaq_flc.fits[DQ]')  # DQ,1
imviz.load_data('jbt7a3kaq_flc.fits[SCI,2]')
imviz.load_data('jbt7a3kaq_flc.fits[DQ,2]')

Screenshot 2021-05-25 132221

Disclaimer: Imviz parser behavior might change in the future depending on how #600 turns out.

Can you close one of the tiles?

Yes, click on the "x" next to "Test" or to the far right but sometimes it closes more than one windows or all of them! I am not sure what drives the inconsistent behavior. @astrofrog , do you know?

Screenshot 2021-05-25 133347

Can you keep moving the tiles?

Yes. Click and drag. There will be dotted lines to guide you.

Screenshot 2021-05-25 135004

@pllim
Copy link
Contributor Author

pllim commented Jun 7, 2021

The bug will be followed up on over at #663 . This feature is marked as complete.

@pllim pllim closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant