Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Stop relying on dev glue-jupyter #533

Closed
pllim opened this issue Apr 15, 2021 · 2 comments · Fixed by #538
Closed

MNT: Stop relying on dev glue-jupyter #533

pllim opened this issue Apr 15, 2021 · 2 comments · Fixed by #538
Assignees
@astrofrog
Labels
imviz Upstream fix required
Milestone
Imviz 1.0

Comments

@pllim
Copy link
Contributor

pllim commented Apr 15, 2021

Once glue-viz/glue-jupyter#213 is in a release, we can change the version pin here:

jdaviz/setup.cfg

Line 25 in 28557a0

glue-jupyter@git+https://github.com/glue-viz/glue-jupyter.git@8e3bb27fda607980317978026fc7a51d0aeb5afa

This is a follow-up of #429
@pllim pllim added this to the Imviz 1.0 milestone Apr 15, 2021
@astrofrog
Copy link
Collaborator

The v0.3 release of glue-jupyter is now in progress, should hopefully be done in a few minutes.

@pllim - once it is on PyPI, would you be happy to check that it works fine and update the dependency list?

@pllim
Copy link
Contributor Author

pllim commented Apr 15, 2021

Yes, that is easy to check via a PR update to setup.cfg once it is out. Thanks!

@pllim pllim mentioned this issue Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astrofrog astrofrog

Labels
imviz Upstream fix required
Projects
None yet
Milestone
Imviz 1.0
Development

Successfully merging a pull request may close this issue.

MNT: Minversion of glupyter is now 0.3 pllim/jdaviz
2 participants
@astrofrog @pllim