-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start implementing 'always-on' MouseInteraction #213
Start implementing 'always-on' MouseInteraction #213
Conversation
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
- Coverage 90.57% 90.47% -0.10%
==========================================
Files 83 82 -1
Lines 3988 3959 -29
==========================================
- Hits 3612 3582 -30
- Misses 376 377 +1
Continue to review full report at Codecov.
|
@astrofrog would be great if you can try again with glue-viz/bqplot-image-gl#47 |
3429997
to
f8bd8a4
Compare
@maartenbreddels - the CI is being a bit slow to start but this is ready for review. |
f8bd8a4
to
bee7c4d
Compare
(I just rebased this) |
This seems to work fine for spacetelescope/jdaviz#429 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the only 'downside' i see is that we'll always get a lot of events. We could possibly add an extra argument to the add_event_callback
which events we want to listen to, and set _mouse_interact.events
based on that. But, we can postpone that for now.
@maartenbreddels - yes good idea. I'll merge this for now and will add something like this in a follow-up PR. |
Is this released? If not what is the timeline? This is blocking spacetelescope/jdaviz#429 |
@maartenbreddels - this is what I have so far but I have run into an issue which is that the print statement to show when mouse interactions are received only works if you first select a tool, e.g. rectangular selection. For some reason it doesn't work before this, when
next
is set toNone
.Note that there is also a default 'click and drag ROI' mouse mode that gets selected when other tools aren't selected - this doesn't seem to play nicely with having a MouseInteration that has a
next
which is the ROIMouseInteraction
, so this will also require some investigation.Note that this requires glue-viz/bqplot-image-gl#46