Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spectra per spaxel v2 #1336

Closed
wants to merge 6 commits into from
Closed

Spectra per spaxel v2 #1336

wants to merge 6 commits into from

Conversation

javerbukh
Copy link
Contributor

Description

This pull request is to address an alternate implementation of #1317 with no spectrum viewer rescaling and deselection of spectra from pixel data from the spectrum viewer after the spectrum per spaxel tool is deactivated.

Related to #1317 (review)

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added cubeviz documentation Explanation of code and concepts labels May 20, 2022
@javerbukh javerbukh mentioned this pull request May 20, 2022
Merged
15 tasks
@javerbukh
Copy link
Contributor Author

Merged into #1317

@javerbukh javerbukh closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickOgle PatrickOgle Awaiting requested review from PatrickOgle

@rosteen rosteen Awaiting requested review from rosteen rosteen will be requested when the pull request is marked ready for review rosteen is a code owner

@pllim pllim Awaiting requested review from pllim pllim will be requested when the pull request is marked ready for review pllim is a code owner

@kecnry kecnry Awaiting requested review from kecnry kecnry will be requested when the pull request is marked ready for review kecnry is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 will be requested when the pull request is marked ready for review bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay will be requested when the pull request is marked ready for review haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 will be requested when the pull request is marked ready for review cshanahan1 is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen will be requested when the pull request is marked ready for review gibsongreen is a code owner

Assignees
No one assigned
Labels
cubeviz documentation Explanation of code and concepts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javerbukh @kecnry