ENH: Image rotation via WCS-only layers #2179
Commits on Jan 17, 2024
-
-
-
-
-
Proposed changes for PR 2179 (ENH: Image rotation via WCS-only layers) (
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <[email protected]> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <[email protected]>
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Update jdaviz/configs/imviz/plugins/links_control/links_control.vue
Co-authored-by: Kyle Conroy <[email protected]>
-
-
-
-
-
-
-
-
Remove unused method and callback hook.
Do not assume everything always has a valid WCS.
-
-
-
Update notebooks/concepts/imviz-wcs-rotation.ipynb
Co-authored-by: P. L. Lim <[email protected]>
-
Update notebooks/concepts/imviz-wcs-rotation.ipynb
Co-authored-by: P. L. Lim <[email protected]>
-
-
-
-
-
-
-
Update jdaviz/configs/imviz/plugins/links_control/links_control.py
Co-authored-by: Kyle Conroy <[email protected]>
-
Apply suggestions from code review
Co-authored-by: Brett M. Morris <[email protected]>
-
-
-
-
-
-
-
-
-
don't re-add layers that were intentionally removed
* instead, show snackbar when layers are removed when switching to WCS-linked
-
don't allow deleting "Default orientation" from data-menu
* other orientation layers can be deleted. If the currently selected orientation is deleted, that viewer will default back to Default orientation
-
fix updating default viewer menu on change in link type
generalization still needs to be made for the multi-viewer case
-
-
-
-
-
-
-
-
-
-
retain behavior only showing markers in viewer where they were created
* with comment explain how we could change this in a follow-up effort, if desired
-
-
-
warning in links_control when markers are present
* linking with a distorted image seems to sometimes result in a skew which can result in markers not exactly lining up where they should on the image. This is a broader problem that needs to be investigated/fixed, but for now we should warn the user.
-
-
-
orientation plugin UI/UX changes
* rename plugin from "Links Control" to "Orientation" (with deprecation) * align by WCS by default * fix layer letter assignment to ignore wcs-only layers * text/layout tweaks in plugin
-
-
update orientation icons and data-menu styling
* data menu to use radio-buttons instead of badge, preset icons throughout dropdown and data-menu
-
improved v-alert styling in plugins
* less padding * font-size consistent with plugin text * black on yellow for accessibility
-
-
-
-
-
(icons no longer change so don't need to be tested)
-
-
* NOTE: will need to update "since" as well as "Links Control" if we decide to rename that as part of this effort.
-
-
More safeguards fix multi viewer linked pan/zoom (or breaking it, not sure) Fix CI mainly by using more conventional ways to adjust the tests take give back same result as main, so also undo the result changes. Deleted unnecessary functions. Better change log, add basic doc. It bothers me that there is no user doc at all. I will add some basic info here. Better doc is already a future ticket. I do not need get_bottom_layer is needed GWCS is also BaseHighLevelWCS, no need to check separately. imviz.link_data API should error out sooner when subsets need to be cleared first. Remove unnecessary check for viewer.data() especially since that might waste memory. More code simplification. And clarify behavior more in doc. Docstring nitpick Nope did not work out as I hoped I think I fixed aper phot
-
-
We do not need the concept notebook anymore
because there is GUI
-
Revert removal of linked pan/zoom new code.
Do not assume data_collection[0] is always real data.
-
Fix linking in batch mode. Apply isort on some messy imports.
-
-
-
Privatize link_image_data because it is breaky
now due to circular call from/to Orientation plugin. In the future, this can be moved to the plugin entirely. Make imviz.link_data call plugin API directly for consistency.
-
-
Co-authored-by: Brett M. Morris <[email protected]>
-
-
Update jdaviz/configs/imviz/plugins/orientation/orientation.py
Co-authored-by: P. L. Lim <[email protected]>
-
Update jdaviz/core/template_mixin.py
Co-authored-by: P. L. Lim <[email protected]>
-
-
-
-
-
-
-
-
-
-
-
-
-
Merge pull request spacetelescope#2589 from pllim/fix-ann-reg-test
TST: Fix ds9_annulus_01.reg test case
-
-
get_interactive_regions returns sky region
when linked by WCS
-
-
Remove unnecessary link_type.lower() calls
and clarify doc a bit more.
-
f-string not recommended for logger
due to security concerns.
-
-
-
Co-authored-by: P. L. Lim <[email protected]>
-
Co-authored-by: P. L. Lim <[email protected]>
-
-
-
-
-
Co-authored-by: P. L. Lim <[email protected]>
-
-
-
-
-
-
-
-
Update jdaviz/core/astrowidgets_api.py
Co-authored-by: P. L. Lim <[email protected]>
-
-
Commits on Jan 18, 2024
-
-
Apply suggestions from code review
Co-authored-by: P. L. Lim <[email protected]>