added circular annulus subset to cubviz toolbar #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshanahan1
requested review from
rosteen,
javerbukh,
pllim,
kecnry,
bmorris3 and
haticekaratay
as code owners
|
Works for me! If you can fix the one code style check we can see if it passes CI as well. I can approve after that. |
|
Tested in standalone. Works great. Thank you! |
kecnry
reviewed
Sep 25, 2023
cshanahan1
force-pushed
the
cubeviz_annulus
branch
from
dd035a6
to
efe2e72
Compare
cshanahan1
force-pushed
the
cubeviz_annulus
branch
from
efe2e72
to
158561b
Compare
kecnry
approved these changes
Sep 25, 2023
|
thanks! ill merge once CI passes |
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a circular annulus subset option to the toolbar.