-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Cubeviz to recognize VLT MUSE data #2504
Conversation
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
if cunit_key in hdr and 'WAVE' in hdr[ctype_key]: | ||
if cunit_key in hdr and 'WAV' in hdr[ctype_key]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any risk here of this catching something we don't want it to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the risk is pretty small given the values are supposedly defined by WCS standards. Do you want me to cross-check with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like there are (currently) three possible matches (WAVE, WAVN, AWAV). Do we need any order of preference to these or are there no cases where multiple ones would be present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need any order of preference to these or are there no cases where multiple ones would be present?
I don't think any sane cube WCS has more than 1 spectral axis at a given time?
If it does, how do we even know which one to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now it would just be somewhat random.... but no need to make the logic more complicated if that case doesn't exist. Let's leave as-is for now. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the reviews! |
…4-on-v3.7.x Backport PR #2504 on branch v3.7.x (BUG: Cubeviz to recognize VLT MUSE data)
Description
This pull request is to address the wavelength unit portion of #2502 .
With this patch:
Performance issues with large cube still exist and are out of scope here.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.