Imviz: Aperture photometry sum in scientific notation #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
commented
Oct 24, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
|
Thank you! Much appreciated |
pllim
force-pushed
the
sum-sci-notation
branch
from
1e8d618
to
42518cd
Compare
pllim
commented
Oct 25, 2023
| @@ -3134,16 +3134,20 @@ def float_precision(column, item): | |||
| if column in ('slice', 'index'): | |||
| # stored in astropy table as a float so we can also store nans, | |||
| # but should display in the UI without any decimals | |||
| return int(item) | |||
| elif column in ('pixel'): | |||
| return f"{item:0.03f}" | |||
There was a problem hiding this comment.
@kecnry , I think "0.03f" can be shortened to "0.3f" but maybe I am missing some subtlety here?
pllim
commented
Oct 25, 2023
|
|
||
| if isinstance(item, SkyCoord): | ||
| return item.to_string('hmsdms', precision=4) | ||
| if isinstance(item, u.Quantity) and not np.isnan(item): | ||
| return (float_precision(column, item.value) * item.unit).to_string() | ||
| return f"{float_precision(column, item.value)} {item.unit.to_string()}" |
There was a problem hiding this comment.
This was the problem: Any formatting from float_precision was lost again because the return value was then converted back to Quantity via * operator. It is unnecessary (and also has extra overhead).
pllim
requested review from
rosteen,
javerbukh,
bmorris3,
haticekaratay and
cshanahan1
as code owners
kecnry
approved these changes
Oct 25, 2023
haticekaratay
approved these changes
Oct 27, 2023
pllim
force-pushed
the
sum-sci-notation
branch
from
42518cd
to
e8ff573
Compare
|
Rebased to resolve change log conflict. Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to show "sum" as scientific notation.
This already exists:
With this PR, this also matches:
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.