remove state-sync for data menu open

[kecnry]

Description

As an alternate option to #2669, this decouples each data-menu from other instances in the same viewer (so only a single menu will be open if multiple instance of the app are being shown).

Fixes #2581

Close #2669

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20b9de5) 91.52% compared to head (f276ed6) 91.53%.
Report is 157 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2670   +/-   ##
=======================================
  Coverage   91.52%   91.53%           
=======================================
  Files         161      161           
  Lines       20196    20196           
=======================================
+ Hits        18485    18486    +1     
+ Misses       1711     1710    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pllim]

Is this a possible side effect? I was switching between linked pan/zoom and linked box-zoom in the first viewer. And then all of a sudden, the order of the tools switched in the first viewer without warning or error. I was caught by surprised.

[pllim]

p.s. I rebased this PR on top of main before I tested it.

[kecnry]

I cannot imagine how that would possibly be related to this, but if you can consistently reproduce here but not on main, I can investigate.

[pllim]

If that tool swapping thing is unrelated, then your patch also fixed the original problem.

I guess it is up to POs to see what users would prefer? Thanks!

[kecnry]

I guess it is up to POs to see what users would prefer?

This was discussed today and the decision was to move forward with review on this PR, and if it doesn't show any major drawbacks, go with this approach since it's a less-significant behavior change.