Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid errors in JS console from new data menu scrolling logic #2707

Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Feb 15, 2024

Description

This pull request avoids JS console messages introduced by #2630 by gracefully existing if parentElement is not defined.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added the 💤backport-v3.8.x on-merge: backport to v3.8.x label Feb 15, 2024
@kecnry kecnry added this to the 3.8.2 milestone Feb 15, 2024
@kecnry kecnry marked this pull request as ready for review February 15, 2024 15:06
@kecnry kecnry added the trivial Only needs one approval instead of two label Feb 15, 2024
Copy link
Contributor

@haticekaratay haticekaratay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Looks good to me!

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (fb3cf40) 90.82% compared to head (be38873) 90.81%.
Report is 4 commits behind head on main.

Files Patch % Lines
jdaviz/style_registry.py 83.78% 6 Missing ⚠️
jdaviz/utils.py 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2707      +/-   ##
==========================================
- Coverage   90.82%   90.81%   -0.02%     
==========================================
  Files         163      164       +1     
  Lines       21503    21572      +69     
==========================================
+ Hits        19530    19590      +60     
- Misses       1973     1982       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry merged commit cdfa868 into spacetelescope:main Feb 15, 2024
17 of 19 checks passed
@kecnry kecnry deleted the data-menu-scroll-avoid-console-errors branch February 15, 2024 15:27
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Feb 15, 2024
pllim added a commit that referenced this pull request Feb 15, 2024
…7-on-v3.8.x

Backport PR #2707 on branch v3.8.x (avoid errors in JS console from new data menu scrolling logic)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial Only needs one approval instead of two 💤backport-v3.8.x on-merge: backport to v3.8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants