Reverse gist_rainbow colors to match order of manual presets #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
added
bug
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
pllim
reviewed
Feb 27, 2024
Co-authored-by: P. L. Lim <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Yup, just caught that and fixed it. |
|
Whew, Github picked up the commits after that push. |
pllim
reviewed
Feb 27, 2024
|
It's testing the same thing as before I just reorganized it slightly to not have to think about skipping an index in reverse order. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2731 +/- ##
==========================================
+ Coverage 88.07% 88.66% +0.59%
==========================================
Files 108 108
Lines 15883 15886 +3
==========================================
+ Hits 13989 14086 +97
+ Misses 1894 1800 -94 ☔ View full report in Codecov by Sentry. |
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Feb 27, 2024
… order of manual presets
pllim
added a commit
that referenced
this pull request
Feb 27, 2024
…1-on-v3.8.x Backport PR #2731 on branch v3.8.x (Reverse gist_rainbow colors to match order of manual presets)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@camipacifici noticed that the RGB colors at n>5 were reversed compared to at n<=5. This fixes the problem.
Before:
After: