Disable cubeviz spectrum-viewer PNG export for now #2777
Conversation
rosteen
added
bug
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
|
There is no spoon. (A special day message.) |
| @@ -187,6 +190,22 @@ def _sync_singleselect(self, event): | |||
| setattr(self, attr, '') | |||
| if attr == 'subset_selected': | |||
| self._set_subset_not_supported_msg() | |||
| elif attr == "viewer_selected" and self.config == "cubeviz": | |||
There was a problem hiding this comment.
Should we swap the conditions here so all the other viz doesn't have to check for attr to begin with?
|
Gotta fix the PEP 8 though. |
| if self.viewer_selected == "spectrum-viewer" and self.viewer_format_selected == "png": | ||
| msg = "Exporting the spectrum viewer as a PNG in Cubeviz is currently disabled" | ||
| else: | ||
| msg = "" | ||
| self.viewer_invalid_msg = msg |
There was a problem hiding this comment.
Can we just call _disable_viewer_format_combo to be consistent with the other cases?
There was a problem hiding this comment.
Done, good thought.
I pushed a fix for that and the PR didn't pick it up 😵 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2777 +/- ##
==========================================
+ Coverage 88.72% 88.81% +0.09%
==========================================
Files 110 110
Lines 16353 16407 +54
==========================================
+ Hits 14509 14572 +63
+ Misses 1844 1835 -9 ☔ View full report in Codecov by Sentry. |
[ci skip] [rtd skip]
|
@pllim this only disables this through the UI, not the API. Probably not worth opening another PR just to fix the changelog though. |
|
Oh, I missed that - it would be super easy to check |
Sure, I can do that. |
|
Oops sorry, my bad w.r.t. change log section. |
Adding a disabled message for this case until we can fix it.