Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update H-Paschen-Brackett.csv #2819

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Conversation

camipacifici
Copy link
Contributor

Description

Fixing typo in line list

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 3.9.1 milestone Apr 19, 2024
@kecnry kecnry added the 💤 backport-v3.9.x on-merge: backport to v3.9.x label Apr 19, 2024
@pllim pllim added bug Something isn't working specviz trivial Only needs one approval instead of two plugin Label for plugins common to multiple configurations labels Apr 19, 2024
@pllim
Copy link
Contributor

pllim commented Apr 19, 2024

What is the frequency column for? Do we need it?

@pllim
Copy link
Contributor

pllim commented Apr 19, 2024

I think this needs a change log. Thanks!

[ci skip] [rtd skip]
to remove unnecessary/misleading columns
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has been agreed to on Slack by @camipacifici and @PatrickOgle , so approving.

@pllim pllim enabled auto-merge April 19, 2024 15:45
@pllim pllim merged commit 5491fc0 into spacetelescope:main Apr 19, 2024
14 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Apr 19, 2024
pllim added a commit that referenced this pull request Apr 19, 2024
…9-on-v3.9.x

Backport PR #2819 on branch v3.9.x (Update H-Paschen-Brackett.csv)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin Label for plugins common to multiple configurations specviz trivial Only needs one approval instead of two 💤 backport-v3.9.x on-merge: backport to v3.9.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants