-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subset plugin: disable update button when no subset selected #2880
Merged
pllim
merged 2 commits into
spacetelescope:main
from
kecnry:subset-create-new-no-update
May 20, 2024
Merged
subset plugin: disable update button when no subset selected #2880
pllim
merged 2 commits into
spacetelescope:main
from
kecnry:subset-create-new-no-update
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin
Label for plugins common to multiple configurations
label
May 20, 2024
kecnry
requested review from
rosteen,
javerbukh,
pllim,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
May 20, 2024 18:47
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2880 +/- ##
=======================================
Coverage 88.72% 88.72%
=======================================
Files 111 111
Lines 17102 17102
=======================================
Hits 15174 15174
Misses 1928 1928 ☔ View full report in Codecov by Sentry. |
rosteen
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple enough!
pllim
approved these changes
May 20, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
May 20, 2024
… when no subset selected
pllim
added a commit
that referenced
this pull request
May 20, 2024
…0-on-v3.10.x Backport PR #2880 on branch v3.10.x (subset plugin: disable update button when no subset selected)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
plugin
Label for plugins common to multiple configurations
UI/UX😍
💤backport-v3.10.x
on-merge: backport to v3.10.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request disables the "update" button when no subset selected.
Screen.Recording.2024-05-20.at.2.45.19.PM.mov
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.