Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show colormap previews in menu #2900

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented May 30, 2024

This shows a preview of each colormap in the menu where you select them. Opening as draft since I'm iterating a bit more with @Jenneh. Currently looks like this:

Screenshot 2024-05-30 at 11 38 47 AM

I'm having an infuriating time trying to get the card element to center within the selection item, if anyone has ideas feel free to chime in.

@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label May 30, 2024
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's one option to "center" by filling the full width

@rosteen rosteen added this to the 4.0 milestone May 30, 2024
@rosteen
Copy link
Collaborator Author

rosteen commented May 30, 2024

@kecnry I implemented your suggestions for centering/filling the width, works well. Thanks!

I also talked to @Jenneh, she doesn't love the text-shadow (looks a little dated apparently) but thinks that being consistent with the layer tabs is more important than figuring out some other way of text outlining for now. Other than that I addressed her feedback by making the card flat and bolding the font.

@rosteen rosteen marked this pull request as ready for review May 30, 2024 17:53
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (50ebc1e) to head (cb18783).
Report is 180 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2900      +/-   ##
==========================================
- Coverage   88.70%   88.69%   -0.01%     
==========================================
  Files         111      111              
  Lines       17125    17122       -3     
==========================================
- Hits        15190    15187       -3     
  Misses       1935     1935              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rosteen
Copy link
Collaborator Author

rosteen commented Jun 3, 2024

Dev test failures are unrelated and I'll count @Jenneh as a second approval (we may revisit this and some related styling later but this is consistent with what exists). Merging.

@rosteen rosteen merged commit 0afaafc into spacetelescope:main Jun 3, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin Label for plugins common to multiple configurations UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants