Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog update for dev on v3.10.3 #2919

Closed
wants to merge 1 commit into from
Closed

Conversation

bmorris3
Copy link
Contributor

Should have done this during the release process for v3.10.2. Apologies!

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@bmorris3 bmorris3 added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Jun 17, 2024
@rosteen
Copy link
Collaborator

rosteen commented Jun 17, 2024

Good catch, thanks,

@bmorris3 bmorris3 enabled auto-merge June 17, 2024 19:31
@bmorris3 bmorris3 disabled auto-merge June 17, 2024 19:41
@bmorris3 bmorris3 closed this Jun 17, 2024
@bmorris3 bmorris3 deleted the bmorris3-patch-1 branch June 17, 2024 19:43
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (4b8be8f) to head (4ebc96f).
Report is 151 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2919   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files         111      111           
  Lines       17178    17178           
=======================================
  Hits        15248    15248           
  Misses       1930     1930           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants