Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual backport of #2934 #3083

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Manual backport of #2934 #3083

merged 1 commit into from
Jul 11, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jul 11, 2024 •
edited
Loading

See #2934. Only conflict was in changelog.

@kecnry
support exporting a plot from an unopened/inactive plugin (spaceteles…
4e8c1b6 
…cope#2934)

* support exporting a plot from an unopened/inactive plugin
* prevent clearing plot selection (under most conditions)
@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Jul 11, 2024
@kecnry kecnry added this to the 3.10.3 milestone Jul 11, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Jul 11, 2024
gibsongreen
gibsongreen approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@gibsongreen gibsongreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set!

bmorris3
bmorris3 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kecnry kecnry merged commit 5a296ce into spacetelescope:v3.10.x Jul 11, 2024
19 checks passed
@kecnry kecnry deleted the backport-2934 branch July 11, 2024 14:20
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.91%. Comparing base (06b3be2) to head (4e8c1b6).
Report is 22 commits behind head on v3.10.x.

Files with missing lines Patch % Lines
jdaviz/core/template_mixin.py 93.75% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           v3.10.x    #3083   +/-   ##
========================================
  Coverage    88.90%   88.91%           
========================================
  Files          111      111           
  Lines        17167    17176    +9     
========================================
+ Hits         15263    15272    +9     
  Misses        1904     1904

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorris3 bmorris3 bmorris3 approved these changes

@gibsongreen gibsongreen gibsongreen approved these changes

@haticekaratay haticekaratay haticekaratay approved these changes

@rosteen rosteen Awaiting requested review from rosteen rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@pllim pllim Awaiting requested review from pllim pllim is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 is a code owner

Assignees
No one assigned
Labels
no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations
Projects
None yet
Milestone
3.10.3
Development

Successfully merging this pull request may close these issues.
4 participants
@kecnry @bmorris3 @gibsongreen @haticekaratay