Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for NIRSpec IRS2 readout mode #3167

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented Aug 26, 2024

Description

#3148 implemented parsers for JWST ramp cubes. JWST/NIRSpec has two readout modes, and it appears that the IRS2 readout modes produce ramp cubes with the order of the x and y axes swapped. This PR identifies that special case and rearranges the axes correctly.

Test this PR with:

from jdaviz import Rampviz

uri = "mast:JWST/product/jw02123001002_0310d_00001_nrs1_uncal.fits"

rampviz = Rampviz()
rampviz.load_data(uri, cache=True)
rampviz.show()

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@github-actions github-actions bot added plugin Label for plugins common to multiple configurations rampviz labels Aug 26, 2024
@bmorris3 bmorris3 added this to the 4.0 milestone Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (a9b559b) to head (0e735d5).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
jdaviz/configs/rampviz/plugins/parsers.py 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3167      +/-   ##
==========================================
- Coverage   88.42%   88.41%   -0.01%     
==========================================
  Files         122      122              
  Lines       18264    18272       +8     
==========================================
+ Hits        16150    16156       +6     
- Misses       2114     2116       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmorris3 bmorris3 merged commit c46a0df into spacetelescope:main Aug 29, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin Label for plugins common to multiple configurations rampviz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants