Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postpone updating stretch hist if image_color_value not yet set #3230

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Oct 18, 2024

Description

This pull request fixes a bug that only seems to happen in lcviz (perhaps because of the order in which data is added to a new image viewer), which caused plot options to crash when selecting an image layer because image_color_value was not yet populated.

Because I have not seen this in imviz, I am marking as no changelog entry needed since it should only affect downstream lcviz. If anyone can reproduce in imviz, then we should add a changelog entry.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Oct 18, 2024
@kecnry kecnry added this to the 4.0.1 milestone Oct 18, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Oct 18, 2024
@kecnry kecnry added the backport-v4.0.x on-merge: backport to v4.0.x label Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.61%. Comparing base (9a1fe09) to head (908c7ee).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...nfigs/default/plugins/plot_options/plot_options.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3230      +/-   ##
==========================================
- Coverage   88.62%   88.61%   -0.01%     
==========================================
  Files         125      125              
  Lines       18775    18777       +2     
==========================================
  Hits        16639    16639              
- Misses       2136     2138       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍🏻

@bmorris3 bmorris3 merged commit f5b3a1d into spacetelescope:main Oct 21, 2024
31 of 35 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Oct 21, 2024
@kecnry kecnry deleted the fix-lcviz-stretch-hist branch October 21, 2024 14:12
kecnry pushed a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.0.x on-merge: backport to v4.0.x no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants