Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add --browser option to CLI #448

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Feb 25, 2021

This allows user to provide non-default browser for Jdaviz to use with. Implementation based on answer from voila-dashboards/voila#843 .

For instance, I need this because WebGL doesn't work on machine's Firefox but it works on Chrome, but default browser is Firefox and I don't have enough admin access to change it.

@pllim pllim added the 💤 enhancement New feature or request label Feb 25, 2021
Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rosteen rosteen merged commit 5ed82dc into spacetelescope:main Feb 26, 2021
@pllim pllim deleted the cli-opt-browser branch February 26, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💤 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants