WIP: Added new info bar and use it to show the coordinate overlay #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you are working on it here, I think it would be desirable to fix the position of |
|
Also, will this PR completely fix #514 or just address part of it? |
|
I think it will address it completely - I'll look into the jumping issues |
Using height: 100% is enough here to always take up all space of the parent. The total height of the entire app can then be specified elsewhere. Part of spacetelescope#503
|
@pllim - does this look better to you now? |
|
Actually in the latest mock-ups the coordinates are in the main toolbar so I'll open another simpler PR to compare. |
|
This has been superseded by #557 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an info bar below the toolbar as per the mockups, and for now this is just used to show the coordinate overlay. At the moment there is just one global info bar, but we could always decide in future how to deal with the multi-viewer case (for now a global one is fine since there is only one mouse over coordinate available at any one time)
This requires #505 and should be rebased once that is merged.
Fix #514