Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Ignore FITS from version control #559

Merged
merged 2 commits into from
Apr 26, 2021
Merged

MNT: Ignore FITS from version control #559

merged 2 commits into from
Apr 26, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 22, 2021

Notebook added in #429 downloads two FITS files into notebooks directory. If not ignored, someone can accidentally add them into version control in the future.

@pllim pllim requested a review from astrofrog April 22, 2021 19:28
ibusko
ibusko approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@ibusko ibusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but with a question: shouldn't we have a more general policy for preventing this kind of accident? For instance, this gitignore file only looks into notebooks. It won't prevent a fits file in another place to be uploaded to the repo.

@pllim
Copy link
Contributor Author

pllim commented Apr 23, 2021

It won't prevent a fits file in another place to be uploaded to the repo.

Yes. Because you don't want it to silently ignore package data that happens to be FITS, in case that is something you want to do in the future.

@pllim pllim merged commit 97c3f4a into spacetelescope:main Apr 26, 2021
@pllim pllim deleted the ignore-fits branch April 26, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibusko ibusko ibusko approved these changes

@rosteen rosteen rosteen approved these changes

@astrofrog astrofrog Awaiting requested review from astrofrog

@duytnguyendtn duytnguyendtn Awaiting requested review from duytnguyendtn

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pllim @ibusko @rosteen