Change default data layer opacity to 1 #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
requested review from
duytnguyendtn,
ibusko,
javerbukh and
rosteen
as code owners
rosteen
reviewed
Apr 27, 2021
There was a problem hiding this comment.
Wow, I didn't know how much this bothered me until I looked at Cubeviz with this change...it looks so much better now in the initial display at max opacity. I confirmed that overplotting a dataset hides the other with opacity set to the max now.
I left two suggestions, settings is very generic and I thought importing as glue_settings would make it more clear what's being set later in the code.
Co-authored-by: Ricky O'Steen <[email protected]>
|
@rosteen - I agree and have accepted your suggestions! |
rosteen
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In glue, the default opacity for data layers is 0.8 - while it might make sense to change the default there, for now the quickest and most past- and future-proof fix is to simply set the default for jdaviz here.
Fixes #535
Fixes #537