Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Temporarily pin maxversion of jwst #637

Closed
wants to merge 1 commit into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented May 25, 2021

Temporarily pin maxversion of jwst until they release hotfix for their pytest plugin entrypoint. Otherwise, you will see this error followed by a bunch of INTERNALERROR in the alldeps job:

CRDS - ERROR -  (FATAL) CRDS server connection and cache load FAILED.  Cannot continue.
 See https://hst-crds.stsci.edu/docs/cmdline_bestrefs/ or https://jwst-crds.stsci.edu/docs/cmdline_bestrefs/
 for more information on configuring CRDS,  particularly CRDS_PATH and CRDS_SERVER_URL. :
 [Errno 2] No such file or directory: '/grp/crds/cache/config/jwst/server_config'

After this is merged, I will open a follow-up issue to unpin in the future.

until they release hotfix for their pytest plugin entrypoint.
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #637 (aa05ee8) into main (6ac1256) will increase coverage by 0.15%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
+ Coverage   59.25%   59.41%   +0.15%     
==========================================
  Files          65       65              
  Lines        3888     3888              
==========================================
+ Hits         2304     2310       +6     
+ Misses       1584     1578       -6     
Impacted Files Coverage Δ
jdaviz/cli.py 42.50% <33.33%> (ø)
jdaviz/configs/imviz/plugins/parsers.py 94.84% <100.00%> (ø)
...configs/default/plugins/data_tools/file_chooser.py 69.14% <0.00%> (+3.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3164914...aa05ee8. Read the comment docs.

Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope it gets fixed soon!

@javerbukh
Copy link
Contributor

I think this has become Schrodinger's PR...it is both merged and unmerged at the moment. Should we just close it?

@pllim
Copy link
Contributor Author

pllim commented May 25, 2021

So weird. Lemme rebase.

@pllim
Copy link
Contributor Author

pllim commented May 25, 2021

Oh yeah... rebase shows a weird log.

@pllim
Copy link
Contributor Author

pllim commented May 25, 2021

Apparently merged in 3115559

@pllim pllim closed this May 25, 2021
@pllim pllim deleted the pin-jwst branch May 25, 2021 15:23
pllim pushed a commit to pllim/jdaviz that referenced this pull request May 25, 2021
MNT: Temporarily pin maxversion of jwst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants