Fix bug with empty snackbar queue #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibusko
requested review from
duytnguyendtn,
javerbukh and
rosteen
as code owners
pllim
added
bug
pllim
approved these changes
Jun 25, 2021
Codecov Report
@@ Coverage Diff @@
## main #703 +/- ##
=======================================
Coverage 60.13% 60.14%
=======================================
Files 65 65
Lines 4099 4100 +1
=======================================
+ Hits 2465 2466 +1
Misses 1634 1634
Continue to review full report at Codecov.
|
rosteen
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found out the bug reported by @rosteen on PR #701 (
IndexError: pop from an empty deque). This didn't happen to me before when testing for the PR itself, but now I saw it when reviewing PR #687.This PR fixes the bug.