Make Imviz panning more seamless

[astrofrog]

Description

This pull request uses the option added in glue-viz/glue-jupyter#246 to expand the image fixed resolution buffer beyond the edge of the axes, making panning more seamless:

This is IMHO an improvement over the default behavior right now but it is not perfect - if one pans too fast one might still reach the 'edge' of the buffer and have to wait for it to refresh. We can make the padding larger but then it will take longer to compute, so we need to find the right balance.

There is another - separate - improvement I would like to make which is to only compute the buffer when the mouse button is released during panning, instead of every 0.5 seconds during panning, but this will be done in a separate PR and may not happen before the MVP deadline, so I wanted to at least get this quick fix in.

The glue-jupyter v0.9 release is in progress so this currently requires glue-jupyter dev, but in <1h it should work fine (and the CI can be restarted once glue-jupyter v0.9 is visible on PyPI)

Fixes #564

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a change log needed? If yes, is it added to CHANGES.rst?
• Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[pllim]

So, is this still going to happen?

#564 (comment)

[pllim]

Going to restart the jobs so they pick up new glue-jupyter release.

[astrofrog]

So, is this still going to happen?

As noted in the description above - not in this PR. I don't think this is specifically MVP critical if what is in this PR is good enough.

[astrofrog]

glue-jupyter v0.9 is out for the record, so this should work properly now.

[pllim]

As noted in the description above - not in this PR. I don't think this is specifically MVP critical if what is in this PR is good enough.

I am just not sure if I should open a follow-up issue for it for just forget about it.

[codecov]

Codecov Report

Merging #864 (6349029) into main (36605e8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #864   +/-   ##
=======================================
  Coverage   68.29%   68.30%           
=======================================
  Files          65       65           
  Lines        4741     4742    +1     
=======================================
+ Hits         3238     3239    +1     
  Misses       1503     1503           

Impacted Files	Coverage Δ
jdaviz/configs/imviz/plugins/viewers.py	41.46% <100.00%> (+0.72%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36605e8...6349029. Read the comment docs.

[astrofrog]

I won't forget about it but feel free to open an issue at glue-jupyter 😀

[pllim]

Care to rebase to resolve conflict? 😅

[pllim]

I rebased locally and am using glue-jupyter 0.9, but I cannot say I can see much difference compared to what is already in main. I am interested to see if @rosteen , @javerbukh , or @ojustino feel otherwise.

[pllim]

I guess I like to pan too much around 47-Tuc. Maybe someone with a more realistic science use case will be happy enough with this... 🤷

[astrofrog]

Just for ease of comparison:

Before

After

[pllim]

I guess it doesn't hurt... 😸

[ojustino]

Side by side, I do notice that there's more area over which you can pan before the lag appears. People who pan aggressively won't notice much, but I think this is a good contribution for those who don't.

[pllim]

Thanks, all!