Fix corruption of FITS tables with unsigned int columns on save and load #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philhodge
approved these changes
Jun 17, 2019
| @@ -58,11 +58,6 @@ def __init__(self, ms, spec, exptime_key): | |||
| self.surf_bright = np.zeros_like(self.flux) | |||
| self.sb_error = np.zeros_like(self.flux) | |||
| log.warning("There is no SURF_BRIGHT column in the input.") | |||
| # xxx temporary self.dq = spec.spec_table.field("dq").copy() | |||
There was a problem hiding this comment.
Only the "# xxx temporary " part of this line should be deleted. The actual assignment to self.dq needs to be done.
There was a problem hiding this comment.
Oh! Oops, thanks.
There was a problem hiding this comment.
(this has been fixed)
| fits_rec = fits.FITS_rec(val) | ||
| fits_rec._coldefs = coldefs | ||
| # FITS_rec needs to know if it should be operating in pseudo-unsigned-ints mode, | ||
| # otherwise it won't properly convert integer columns with TZEROn before saving. | ||
| fits_rec._uint = uint |
There was a problem hiding this comment.
Is this used in astropy.io.fits?
There was a problem hiding this comment.
Yes, here. The else... is where it was changing the dtype to float64.
|
Shall we go ahead and merge this? |
This was referenced Jun 21, 2019
This was referenced Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3655
The problem on save turned out to be less of an astropy bug and more of a missing feature -- the public API doesn't currently allow us to put a FITS_rec into "pseudo unsigned integer" mode. We were already messing with astropy implementation details by setting
_colrefsdirectly, so I don't think it's a big deal to also set_uint.The problem on load is, I think, an astropy bug. I filed an issue and added a workaround here, which is to overwrite the incorrect FITS_rec dtype.