JP-2604: Update ref file schemas with current CRDS selectors #6866
Conversation
|
The test now runs locally, with the fix mentioned in the stdatamodels issue filed here. I don't know if the change is at all reasonable, so hoping someone who knows more about that repo can weigh in. |
tapastro
force-pushed
the
jp-2604-ref-schema-selectors
branch
from
fdd8a32
to
ae4bcfd
Compare
|
Pending an stdatamodels release, I'm still working on how to retrieve the files from CRDS during this test. Work on my local machine had initially used either central store or local cache, but the latest commit should cache files in the temporary test environment. Documentation still a WIP. |
|
The new test is failing in (I believe) the expected fashion, as it's missing the recent PR to stdatamodels. Still working on documentation updates... |
Codecov Report
@@ Coverage Diff @@
## master #6866 +/- ##
==========================================
+ Coverage 79.32% 79.36% +0.04%
==========================================
Files 418 418
Lines 37171 37171
==========================================
+ Hits 29485 29501 +16
+ Misses 7686 7670 -16
Continue to review full report at Codecov.
|
tapastro
force-pushed
the
jp-2604-ref-schema-selectors
branch
from
92017cc
to
858c9fc
Compare
|
With up-to-date stdatamodels, Jenkins run passes successfully: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/334/ Docs updated and build succesfully. If no release is made for stdatamodels, this will introduce a unit test that fails until a release is made. Besides that, this PR should be good to merge. |
|
Wanted to run one more set of regtests before merging - getting a bunch of errors related to what looks like a set_telescope_pointing update? Is this schema-related? https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/341/#showFailuresLink |
SIAF update? Or do we use a locked down version in our tests? |
Ah, of course. New version released three hours ago. That'd do it! Guess someone will have to hit the big red button on those later. |
| @@ -1,6 +1,7 @@ | |||
| 1.5.3 (unreleased) | |||
| ================== | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Huh. Are 2 blank lines required below a release heading?
There was a problem hiding this comment.
Hmm, that might have been the result of a poorly-attempted merge conflict... 😬
There was a problem hiding this comment.
No biggy. Can be fixed in the next PR.
Closes #
Resolves JP-2604
Description
This PR addresses outdated reference file schemas that were lacking structure for current CRDS selectors, causing possible issues when creating new reference file datamodels from scratch. A test has been created but could use some polishing before being added.
Checklist