JP-3695: Clean up unnecessary copies #8676
Conversation
| @@ -79,7 +79,6 @@ def do_correction(input_model, emicorr_model, save_onthefly_reffile, **pars): | |||
| will operate. Valid parameters include: | |||
| save_intermediate_results - saves the output into a file and the | |||
| reference file (if created on-the-fly) | |||
| user_supplied_reffile - reference file supplied by the user | |||
There was a problem hiding this comment.
This should be removed from the docs as well, if it's not referenced in the step.
There was a problem hiding this comment.
I removed this line already, not sure why it still showed up. I double checked now and it is not there.
There was a problem hiding this comment.
It's still listed in the documentation pages - that's where it also needs to be pulled.
There was a problem hiding this comment.
ah! I see it now, thank you
| @@ -39,8 +41,7 @@ def process(self, input): | |||
|
|
|||
| # Try to open the input as a regular RampModel | |||
| try: | |||
| input_model = datamodels.RampModel(input) | |||
|
|
|||
| input_model = datamodels.RampModel(step_input) | |||
There was a problem hiding this comment.
The following lines (49 and 56) need to have input updated to step_input, it's causing the fgs regression test failures.
There was a problem hiding this comment.
good catch, thank you!
|
|
||
| # Before the ramp_fit() call, copy the input model ("_W" for weighting) | ||
| # for later reconstruction of the fitting array tuples. | ||
| input_model_W = copy.copy(input_model) |
There was a problem hiding this comment.
Removing this copy changes downstream behavior when the ramp_fit algorithm is 'OLS'. This is no longer the default algorithm in our tests, but a diff can be seen if setting the algorithm to 'OLS'. I think this part needs to be reverted, at least until we remove the 'OLS' algorithm.
There was a problem hiding this comment.
I reverted these lines.
|
That's fine, you can mark it with the appropriate no-changelog tag then. |
zacharyburnett
added
no-changelog-entry-needed
and removed
no-changelog-entry-needed
labels
|
Latest regtest run was clean: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1741/ Merging! |
Partially Resolves JP-3695
Closes #
This PR addresses removing the unnecessary copies of all steps in the Detector1 pipeline. The same needs to be done for the stage2 pipelines.
Copies are made at the _step.py level, only if the step is not skipped.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR