Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add id to crds-context step #119

Closed
wants to merge 0 commits into from

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Feb 15, 2023

re-add the crds-context id that was removed in 7690332

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@braingram braingram added the no-changelog-entry-needed Trivial change that doesn't need an entry in the change log label Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 49.96% // Head: 49.96% // No change to project coverage 👍

Coverage data is based on head (7d905d1) compared to base (9639bca).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   49.96%   49.96%           
=======================================
  Files         121      121           
  Lines        7669     7669           
=======================================
  Hits         3832     3832           
  Misses       3837     3837           
Flag Coverage Δ
unit 49.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@braingram
Copy link
Collaborator Author

Tested after re-adding crds-context to get a correct cache key and the same errors occurred as those in #114

Removing the crds cache altogether also results in the same erors:
https://github.com/spacetelescope/stdatamodels/actions/runs/4187846272/jobs/7258231109#step:8:1098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Trivial change that doesn't need an entry in the change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant