add HDUList support to asdf_in_fits.open #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
feature/asdf_in_fits_hdu
branch
from
6c9830f
to
c965565
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 73.11% 73.13% +0.01%
==========================================
Files 101 101
Lines 5442 5445 +3
==========================================
+ Hits 3979 3982 +3
Misses 1463 1463
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
braingram
force-pushed
the
feature/asdf_in_fits_hdu
branch
from
c965565
to
e190060
Compare
braingram
force-pushed
the
feature/asdf_in_fits_hdu
branch
from
e190060
to
1321666
Compare
braingram
force-pushed
the
feature/asdf_in_fits_hdu
branch
from
1321666
to
e2bc0c5
Compare
braingram
force-pushed
the
feature/asdf_in_fits_hdu
branch
from
e2bc0c5
to
f18eab2
Compare
WilliamJamieson
approved these changes
Mar 8, 2023
|
Thanks! Please let me know when a new stdatamodels is released, so I can revisit using this downstream. Really appreciate all the quick fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for reading ASDF data from an already opened HDUList.
Fixes #135
Also fixes sphinx link in docs that was in #122
Checklist
CHANGES.rst(either inBug FixesorChanges to API)