Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move build configuration into pyproject.toml #98

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Jun 16, 2022

use PEP621 and ini2toml / peppyproject to move metadata into pyproject.toml

@zacharyburnett zacharyburnett added the no-changelog-entry-needed Trivial change that doesn't need an entry in the change log label Dec 15, 2022
@zacharyburnett zacharyburnett self-assigned this Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 49.94% // Head: 49.96% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (067c694) compared to base (a9e69b0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   49.94%   49.96%   +0.01%     
==========================================
  Files         122      121       -1     
  Lines        7672     7669       -3     
==========================================
  Hits         3832     3832              
+ Misses       3840     3837       -3     
Flag Coverage Δ
unit 49.96% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett force-pushed the consolidate_build_config branch 2 times, most recently from 0542446 to 8e78e17 Compare December 22, 2022 16:18
@zacharyburnett zacharyburnett marked this pull request as ready for review January 24, 2023 17:53
@WilliamJamieson
Copy link
Contributor

Can this wait until #112 is merged?

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@zacharyburnett zacharyburnett force-pushed the consolidate_build_config branch 2 times, most recently from 3f8f11a to 5c710ff Compare February 6, 2023 13:13
@zacharyburnett zacharyburnett merged commit 1c51d86 into spacetelescope:master Feb 14, 2023
@zacharyburnett zacharyburnett deleted the consolidate_build_config branch February 14, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Trivial change that doesn't need an entry in the change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants