Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update opd thermal slew test, in particular for a change in pupil segment data file #396

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Jan 6, 2021

As discussed & debugged on slack with @kjbrooks : a change in the jwpupil_segment.fits data file to more accurately handle pixels at segment boundaries (see #393) led to a failing test for the thermal slew OPD. It's not necessary to maintain precise agreement at floating-point machine precision for this, so the correct fix is to update the test code to a new expected value. I did this, with a check for the data file version to use the right value with or without the updated data files.

I also added a test check of the OPD's rms as well as the max, so that the test checks more than just a single pixel in the image. This too has an expected value that depends on which data file version is used.

For the record here's the slight difference in the two data files:

jwst_linear_model_segmap_comparison

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #396 (9ef7497) into develop (aaca6cf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #396   +/-   ##
========================================
  Coverage    48.29%   48.30%           
========================================
  Files           14       14           
  Lines         5721     5722    +1     
========================================
+ Hits          2763     2764    +1     
  Misses        2958     2958           
Impacted Files Coverage Δ
webbpsf/opds.py 38.50% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca6cf...9ef7497. Read the comment docs.

@mperrin mperrin merged commit ec6ad87 into spacetelescope:develop Jan 6, 2021
@mperrin mperrin deleted the update_thermal_slew_test_for_segment_data_file branch November 6, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants