update opd thermal slew test, in particular for a change in pupil segment data file #396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed & debugged on slack with @kjbrooks : a change in the
jwpupil_segment.fits
data file to more accurately handle pixels at segment boundaries (see #393) led to a failing test for the thermal slew OPD. It's not necessary to maintain precise agreement at floating-point machine precision for this, so the correct fix is to update the test code to a new expected value. I did this, with a check for the data file version to use the right value with or without the updated data files.I also added a test check of the OPD's rms as well as the max, so that the test checks more than just a single pixel in the image. This too has an expected value that depends on which data file version is used.
For the record here's the slight difference in the two data files: