Add notebook to help test sign convention #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #418 +/- ##
========================================
Coverage 48.59% 48.59%
========================================
Files 14 14
Lines 5772 5772
========================================
Hits 2805 2805
Misses 2967 2967 Continue to review full report at Codecov.
|
|
Thanks again, very useful. I adapted this into unit test format in #419 |
|
Superseded by #419. |
mperrin
added a commit
that referenced
this pull request
Mar 1, 2021
add unit test for sign convention; adapted from notebook version in PR #418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for v1.0 release, here's a notebook to help debug/check that we get our signs correct.