Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace griddata with RegularGridInterpolator for distortions #429

Merged
merged 7 commits into from
Mar 29, 2021

Commits on Mar 23, 2021

  1. detector_position settings

    Remove constraints on detector_pixel that it should be an integer from 0 to npix. Since these values correspond to SIAF aperture 'sci' coords and only get converted to 'tel' (V2/V3), there's no reason to constrain to the detector focal plane, especially since it is possible to simulate PSFs outside this region via SI WFE extrapolation. Also, fractional values are necessary to track small shifts (e.g., coronagrahic masks) and provide sub-pixel coordinate transformations.
    JarronL committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    bf68aa7 View commit details
    Browse the repository at this point in the history
  2. Don't set attribute to map()

    Explicitly set x,y=map() in order to force map to return the values, otherwise it gets saved as an object, and we are unable to subscript the values as expected.
    JarronL committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    3e66ef7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f1ca2b6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dcdc2f2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0791cc3 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Remove unused import calls

    JarronL committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    061e065 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0a69ab View commit details
    Browse the repository at this point in the history