Update rotation sign for consistency after poppy PR 411 #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…411, to maintain correct PSF orientations
Codecov Report
@@ Coverage Diff @@
## develop #438 +/- ##
===========================================
+ Coverage 48.38% 48.46% +0.07%
===========================================
Files 14 14
Lines 5899 5877 -22
===========================================
- Hits 2854 2848 -6
+ Misses 3045 3029 -16
Continue to review full report at Codecov.
|
shanosborne
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poppy PR spacetelescope/poppy#411 fixed a sign inconsistency in rotation handling. This PR updates the rotation sign used in webbpsf for consistency with that. This is needed to get the correct orientation for MIRI or NIRSpec PSF diffraction patterns again after that poppy PR.