Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code for GUIs and obssim #439

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Apr 2, 2021

Closes #413 to delete and remove the deprecated GUIs

Also removes obssim.py, the long-unused code for simulating a scene with multiple sources. This code hasn't ever really been used, and is superseded by other observation simulation tools in particular MIRAGE, pyNRC, and MIRISIM.

@mperrin mperrin requested a review from shanosborne April 2, 2021 04:59
@mperrin mperrin added this to the 1.0.0 milestone Apr 2, 2021
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #439 (9cf0ddb) into develop (7755bc1) will increase coverage by 14.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #439       +/-   ##
============================================
+ Coverage    48.46%   63.02%   +14.56%     
============================================
  Files           14       11        -3     
  Lines         5877     4408     -1469     
============================================
- Hits          2848     2778       -70     
+ Misses        3029     1630     -1399     
Impacted Files Coverage Δ
webbpsf/__init__.py 77.77% <100.00%> (+7.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7755bc1...9cf0ddb. Read the comment docs.

Copy link
Contributor

@shanosborne shanosborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mperrin mperrin merged commit 36cbadf into spacetelescope:develop Apr 2, 2021
@mperrin mperrin deleted the remove_deprecated branch November 6, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete and remove deprecated GUIs
2 participants