Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify jitter arcseconds per axis #442

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Conversation

robelgeda
Copy link
Contributor

No description provided.

@robelgeda robelgeda requested a review from mperrin April 7, 2021 17:27
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #442 (2eff127) into develop (ea3b08c) will increase coverage by 14.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #442       +/-   ##
============================================
+ Coverage    48.60%   63.07%   +14.46%     
============================================
  Files           14       11        -3     
  Lines         5773     4409     -1364     
============================================
- Hits          2806     2781       -25     
+ Misses        2967     1628     -1339     
Impacted Files Coverage Δ
webbpsf/distortion.py 81.81% <0.00%> (-13.31%) ⬇️
webbpsf/utils.py 61.94% <0.00%> (-1.66%) ⬇️
webbpsf/opds.py 38.90% <0.00%> (-1.29%) ⬇️
webbpsf/obssim.py
webbpsf/tkgui.py
webbpsf/wxgui.py
webbpsf/roman.py 90.00% <0.00%> (+0.22%) ⬆️
webbpsf/jupyter_gui.py 6.17% <0.00%> (+0.53%) ⬆️
webbpsf/webbpsf_core.py 81.00% <0.00%> (+2.30%) ⬆️
webbpsf/__init__.py 77.77% <0.00%> (+7.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3b08c...2eff127. Read the comment docs.

@mperrin
Copy link
Collaborator

mperrin commented Apr 7, 2021

Are there any other places this should be clarified, for instance any of the function doc strings?

@robelgeda
Copy link
Contributor Author

I think this is the only place we mention it. The rest is in Poppy. I will make a quick PR for Poppy now.

@robelgeda
Copy link
Contributor Author

I have added some pointers in the underlying doc strings:

spacetelescope/poppy#427

@mperrin mperrin merged commit 774bb90 into spacetelescope:develop Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants